Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8978 )
Change subject: KUDU-2202: support for removing data directories (take two) ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/8978/8/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/8978/8/src/kudu/fs/data_dirs.cc@699 PS8, Line 699: RETURN_NOT_OK_PREPEND( : PathInstanceMetadataFile::CheckIntegrity(loaded_instances), : Substitute("could not verify integrity of files after data directory update: $0", : JoinStrings(GetDataDirs(), ","))); > nit: could merge this CheckIntegrity with the above with: Yeah the added encapsulation isn't a bad thing, but bear in mind that we'll only end up down here if we're in UPDATE_ON_DISK mode (L659), so the consistency_check condition is guaranteed to be true. http://gerrit.cloudera.org:8080/#/c/8978/8/src/kudu/fs/data_dirs.cc@812 PS8, Line 812: IGNORE_CONSISTENCY > nit: IGNORE_INCONSISTENCY Done -- To view, visit http://gerrit.cloudera.org:8080/8978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacb650115bcdf055542ef2777641a3201fc8e30b Gerrit-Change-Number: 8978 Gerrit-PatchSet: 8 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 20:14:51 +0000 Gerrit-HasComments: Yes
