Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9069 )
Change subject: Kudu-2126: Add conditional check to prevent unnecessary fsyncs ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/9069/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9069/1//COMMIT_MSG@7 PS1, Line 7: Kudu-2126: Add conditional check to prevent unnecessary fsyncs > nit: we always capitalize jira names like KUDU-2126 Done http://gerrit.cloudera.org:8080/#/c/9069/1/src/kudu/integration-tests/delete_tablet-itest.cc File src/kudu/integration-tests/delete_tablet-itest.cc: http://gerrit.cloudera.org:8080/#/c/9069/1/src/kudu/integration-tests/delete_tablet-itest.cc@168 PS1, Line 168: // Kudu-2126 : Ensure that DeleteTablet RPCs does not do double fsyncs. > nit: same thing about capitalization Done http://gerrit.cloudera.org:8080/#/c/9069/1/src/kudu/integration-tests/delete_tablet-itest.cc@183 PS1, Line 183: table > tablets Done http://gerrit.cloudera.org:8080/#/c/9069/1/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/9069/1/src/kudu/tablet/tablet_metadata.cc@528 PS1, Line 528: flush_count_for_tests_++; > seems we should only increment this down below where we actually do the flu Done http://gerrit.cloudera.org:8080/#/c/9069/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/9069/1/src/kudu/tserver/ts_tablet_manager.cc@797 PS1, Line 797: // Kudu-2126 : if tablet is already tombstoned, then a request to tombstone > nit: same formatting Done -- To view, visit http://gerrit.cloudera.org:8080/9069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idde8b413374f43ca2ef09339f0f412208f03685e Gerrit-Change-Number: 9069 Gerrit-PatchSet: 1 Gerrit-Owner: Jeffrey F. Lukman <[email protected]> Gerrit-Reviewer: Jeffrey F. Lukman <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Jan 2018 01:18:25 +0000 Gerrit-HasComments: Yes
