Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9069 )
Change subject: KUDU-2126: Add conditional check to prevent unnecessary fsyncs ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Looks good, thanks for the quick turnaround! http://gerrit.cloudera.org:8080/#/c/9069/2/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: http://gerrit.cloudera.org:8080/#/c/9069/2/src/kudu/tablet/tablet_metadata.h@379 PS2, Line 379: int flush_count_for_tests_; > I did, but this method is just easier to implement That's fair. SGTM. -- To view, visit http://gerrit.cloudera.org:8080/9069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idde8b413374f43ca2ef09339f0f412208f03685e Gerrit-Change-Number: 9069 Gerrit-PatchSet: 3 Gerrit-Owner: Jeffrey F. Lukman <[email protected]> Gerrit-Reviewer: Jeffrey F. Lukman <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 20 Jan 2018 03:03:59 +0000 Gerrit-HasComments: Yes
