Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9069 )
Change subject: Kudu-2126: Add conditional check to prevent unnecessary fsyncs ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9069/1/src/kudu/tablet/metadata.proto File src/kudu/tablet/metadata.proto: http://gerrit.cloudera.org:8080/#/c/9069/1/src/kudu/tablet/metadata.proto@66 PS1, Line 66: // A tablet state is set to TABLET_DATA_DELETED when a tablet is permanently deleted : // from all tablet servers and this state is a terminal state. : // Therefore, the tablet should not be allowed to transition back to any other state. : > I think the bit about it being a "roll-forward" state is useful. Particular I will remove this change for now. If this change is still needed, Mike will submit a separate change later. -- To view, visit http://gerrit.cloudera.org:8080/9069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idde8b413374f43ca2ef09339f0f412208f03685e Gerrit-Change-Number: 9069 Gerrit-PatchSet: 1 Gerrit-Owner: Jeffrey F. Lukman <[email protected]> Gerrit-Reviewer: Jeffrey F. Lukman <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Jan 2018 01:30:21 +0000 Gerrit-HasComments: Yes
