Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9048 )
Change subject: rpc: micro-optimize delayed task handling ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9048/1/src/kudu/rpc/periodic-test.cc File src/kudu/rpc/periodic-test.cc: http://gerrit.cloudera.org:8080/#/c/9048/1/src/kudu/rpc/periodic-test.cc@274 PS1, Line 274: [&] { : // No-op. : }, > Nit: combine into one line: Done http://gerrit.cloudera.org:8080/#/c/9048/1/src/kudu/rpc/periodic-test.cc@278 PS1, Line 278: PeriodicTimer::Options())); > You can omit this. Done http://gerrit.cloudera.org:8080/#/c/9048/1/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: http://gerrit.cloudera.org:8080/#/c/9048/1/src/kudu/rpc/reactor.cc@695 PS1, Line 695: void DelayedTask::TimerHandler(ev::timer& watcher, int revents) { > warning: parameter 'watcher' is unused [misc-unused-parameters] Done -- To view, visit http://gerrit.cloudera.org:8080/9048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b6be5ef7e8f464f3bc4c62f904e2692b30ddc65 Gerrit-Change-Number: 9048 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 24 Jan 2018 02:29:33 +0000 Gerrit-HasComments: Yes
