Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9048 )
Change subject: rpc: micro-optimize delayed task handling ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9048/3/src/kudu/rpc/periodic-test.cc File src/kudu/rpc/periodic-test.cc: http://gerrit.cloudera.org:8080/#/c/9048/3/src/kudu/rpc/periodic-test.cc@270 PS3, Line 270: SCOPED_CLEANUP({ messenger->Shutdown(); }); > Just for my own education: any reason why we use SCOPED_CLEANUP() here inst We usually use this pattern for any place where we set up something that needs special cleanup. That way if someone added any early return down below (eg an ASSERT) we'd be guaranteed that the cleanup would run. -- To view, visit http://gerrit.cloudera.org:8080/9048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b6be5ef7e8f464f3bc4c62f904e2692b30ddc65 Gerrit-Change-Number: 9048 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 01:47:59 +0000 Gerrit-HasComments: Yes
