Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9128 )
Change subject: env: properly use fdatasync on Linux ...................................................................... env: properly use fdatasync on Linux A previous commit attempted to make env OSX-compatible by checking whether fdatasync was defined and using fsync in the case that it was not. However, that commit was buggy since it used #ifndef. fdatasync is never a preprocessor macro, so it never was "defined" and we always ended up using fsync regardless of the FLAGS_env_use_fsync value. Change-Id: I366df37670ec241cbee6dcfe0efa56af7189e9a2 Reviewed-on: http://gerrit.cloudera.org:8080/9128 Reviewed-by: Dan Burkert <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/util/env_posix.cc 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I366df37670ec241cbee6dcfe0efa56af7189e9a2 Gerrit-Change-Number: 9128 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
