Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9137 )
Change subject: internal_mini_cluster: support Cluster/LogVerifier ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/consensus/log_reader.cc File src/kudu/consensus/log_reader.cc: http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/consensus/log_reader.cc@101 PS1, Line 101: scoped_refptr<LogIndex> index, > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/integration-tests/cluster_verifier.cc File src/kudu/integration-tests/cluster_verifier.cc: http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/integration-tests/cluster_verifier.cc@42 PS1, Line 42: using std::vector; > warning: using decl 'unique_ptr' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/integration-tests/mini_cluster_fs_inspector.h File src/kudu/integration-tests/mini_cluster_fs_inspector.h: http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/integration-tests/mini_cluster_fs_inspector.h@63 PS1, Line 63: std::string WalDirForTS(int idx) const; > warning: function 'kudu::itest::MiniClusterFsInspector::WalDirForTS' has a Done http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/integration-tests/mini_cluster_fs_inspector.h@104 PS1, Line 104: Status CheckTabletDataStateOnTS(int index, > warning: function 'kudu::itest::MiniClusterFsInspector::CheckTabletDataStat Done http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/integration-tests/mini_cluster_fs_inspector.cc File src/kudu/integration-tests/mini_cluster_fs_inspector.cc: http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/integration-tests/mini_cluster_fs_inspector.cc@26 PS1, Line 26: #include "kudu/fs/fs_manager.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/integration-tests/mini_cluster_fs_inspector.cc@345 PS1, Line 345: entry, disallowed_filter); > warning: string concatenation results in allocation of unnecessary temporar Done http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: http://gerrit.cloudera.org:8080/#/c/9137/1/src/kudu/tablet/tablet_bootstrap.cc@46 PS1, Line 46: #include "kudu/consensus/log_index.h" > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/9137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I228a6e3ba1a42db4e243ffdc5116f0c60ee04a84 Gerrit-Change-Number: 9137 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 25 Jan 2018 19:52:57 +0000 Gerrit-HasComments: Yes
