Hello Tidy Bot, Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9137
to look at the new patch set (#6).
Change subject: internal_mini_cluster: support Cluster/LogVerifier
......................................................................
internal_mini_cluster: support Cluster/LogVerifier
This patch encapsulates MiniClusterFsInspector into an abstract class,
subclasses it as the existing external cluster inspector, and introduces
a new subclass for inspecting internal clusters. With these classes, the
LogVerifier, and thus, the ClusterVerifier can support both External-
and InternalMiniClusters.
The LogVerifier would originally open a read-only FsManager (which in
turn would open a BlockManager and a DataDirManager) per server and pass
it to the LogReader to inspect the WALs. Instead, the LogVerifier now
creates a MiniClusterFsInspector, which is more lightweight and defined
per MiniCluster. To the LogReader, it passes the WAL directory and an
env, which is all the LogReader needed from the FsManager in the first
place.
To test, I updated a test case in ts_tablet_manager-itest to make use of
the new ClusterVerifier with an internal cluster. CheckCluster() uses a
LogVerifier, which in this case uses an InternalMiniClusterFsInspector.
Change-Id: I228a6e3ba1a42db4e243ffdc5116f0c60ee04a84
---
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_reader.h
M src/kudu/fs/fs_manager.h
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.h
A src/kudu/integration-tests/internal_mini_cluster_fs_inspector.h
M src/kudu/integration-tests/log_verifier.cc
M src/kudu/integration-tests/log_verifier.h
R src/kudu/integration-tests/mini_cluster_fs_inspector.cc
A src/kudu/integration-tests/mini_cluster_fs_inspector.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/tablet/tablet_bootstrap.cc
15 files changed, 392 insertions(+), 321 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/9137/6
--
To view, visit http://gerrit.cloudera.org:8080/9137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I228a6e3ba1a42db4e243ffdc5116f0c60ee04a84
Gerrit-Change-Number: 9137
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
