Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9176 )
Change subject: KUDU-2279 (part 2): metrics: only emit changed metrics in metrics log ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9176/2/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/9176/2/src/kudu/util/metrics.cc@357 PS2, Line 357: Metric::IncrementEpoch(); Also, if we want to make sure hitting /metrics doesn't change the epoch, we should add a quick test for it. -- To view, visit http://gerrit.cloudera.org:8080/9176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia26be99a1fa96d52e2ca0905844d56c096d3778e Gerrit-Change-Number: 9176 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 02 Feb 2018 20:17:13 +0000 Gerrit-HasComments: Yes
