Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9176 to look at the new patch set (#3). Change subject: KUDU-2279 (part 2): metrics: only emit changed metrics in metrics log ...................................................................... KUDU-2279 (part 2): metrics: only emit changed metrics in metrics log This adds a global 'metrics epoch' which can be externally incremented. When metrics are modified, they remember the epoch of their most recent modification. When we dump metrics, we can pass a lower bound in order to see only metrics which have been modified in or after a given epoch. This patch updates the metrics logging to only emit metrics that have changed in each successive line. This should substantially reduce the size and CPU cost of metric logging on servers with thousands of tablets. Change-Id: Ia26be99a1fa96d52e2ca0905844d56c096d3778e --- M src/kudu/server/server_base.cc M src/kudu/util/metrics-test.cc M src/kudu/util/metrics.cc M src/kudu/util/metrics.h 4 files changed, 141 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/9176/3 -- To view, visit http://gerrit.cloudera.org:8080/9176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia26be99a1fa96d52e2ca0905844d56c096d3778e Gerrit-Change-Number: 9176 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>