Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9177 )
Change subject: KUDU-2279 (part 3): metrics: don't emit untouched metrics to log ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9177/1/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/9177/1/src/kudu/util/metrics.h@434 PS1, Line 434: gauges may be non-zero and then reset to zero > aren't there counters we increment by negative amounts nope, that's not allowed/encouraged -- CM at least assumes that if a counter goes down, it means it restarted, and adds the new value to the previously-seen value. -- To view, visit http://gerrit.cloudera.org:8080/9177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d2c4640e54c91791fab9c420215bafa3fe8f20 Gerrit-Change-Number: 9177 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Sat, 03 Feb 2018 01:08:05 +0000 Gerrit-HasComments: Yes
