Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9255 )

Change subject: WIP [non_voter-itest] stress test for the 3-4-3 replacement 
scheme
......................................................................


Patch Set 1:

(4 comments)

Nice torture test

http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/cluster_verifier.h
File src/kudu/integration-tests/cluster_verifier.h:

http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/cluster_verifier.h@79
PS1, Line 79:  DoKsck
nit: maybe rename to RunKsck() since DoKsck() sounds like the name of an 
internal method


http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc:

http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1915
PS1, Line 1915: too chatty, so logging error and fatal messages only
nit: comment punctuation here and below


http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1916
PS1, Line 1916:     "--raft_prepare_replacement_before_eviction=true",
consider adding --tablet_copy_early_session_timeout_prob=.2 to create more 
tablet copy failures and chaos


http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1988
PS1, Line 1988: tablet_id_
always the same tablet?



--
To view, visit http://gerrit.cloudera.org:8080/9255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I036a882f7e9132a5c26013227c50c0699b59ed6e
Gerrit-Change-Number: 9255
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Sat, 10 Feb 2018 03:08:42 +0000
Gerrit-HasComments: Yes

Reply via email to