Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9255 )
Change subject: [itest] stress test for replica replacement ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/cluster_verifier.h File src/kudu/integration-tests/cluster_verifier.h: http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/cluster_verifier.h@79 PS1, Line 79: the ks > nit: maybe rename to RunKsck() since DoKsck() sounds like the name of an in Done http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc: http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1915 PS1, Line 1915: > nit: comment punctuation here and below Done http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1916 PS1, Line 1916: > consider adding --tablet_copy_early_session_timeout_prob=.2 to create more That's a good idea! Done. http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1939 PS1, Line 1939: > warning: either cast from 'int' to 'long' is ineffective, or there is loss Done http://gerrit.cloudera.org:8080/#/c/9255/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1988 PS1, Line 1988: > always the same tablet? woops, indeed. It will make sense to do that for different tablets. -- To view, visit http://gerrit.cloudera.org:8080/9255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I036a882f7e9132a5c26013227c50c0699b59ed6e Gerrit-Change-Number: 9255 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 12 Feb 2018 07:23:45 +0000 Gerrit-HasComments: Yes
