Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9255 )
Change subject: KUDU-2274 [itest] stress test for replica replacement ...................................................................... Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/9255/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9255/5//COMMIT_MSG@11 PS5, Line 11: is are http://gerrit.cloudera.org:8080/#/c/9255/5/src/kudu/integration-tests/raft_consensus_stress-itest.cc File src/kudu/integration-tests/raft_consensus_stress-itest.cc: http://gerrit.cloudera.org:8080/#/c/9255/5/src/kudu/integration-tests/raft_consensus_stress-itest.cc@236 PS5, Line 236: nit: why not iteration++ here? http://gerrit.cloudera.org:8080/#/c/9255/5/src/kudu/integration-tests/raft_consensus_stress-itest.cc@277 PS5, Line 277: if (ksck_failures_in_a_row > FLAGS_test_max_ksck_failures) { : // Suspecting a Raft consensus failure while running ksck with shorter : // timeout (see above). Run an extra round of ksck with the regular timeout : // to verify that replicas haven't really converged and, if so, just bail : // right at this point. : const auto& s = v.RunKsck(); : if (!s.ok()) { : FAIL() << Substitute("$0: tablet replicas haven't converged", s.ToString()); : } : } isn't this the same as line 288 where we run v.CheckCluster() ? -- To view, visit http://gerrit.cloudera.org:8080/9255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I036a882f7e9132a5c26013227c50c0699b59ed6e Gerrit-Change-Number: 9255 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 20 Feb 2018 23:42:10 +0000 Gerrit-HasComments: Yes
