Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 )
Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/8823/12/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/8823/12/src/kudu/client/client.h@1740 PS12, Line 1740: When @c READ_YOUR_WRITES is specified, the client will perform a read : /// such that it follows all previously known writes and reads from this client. : /// Specifically this mode: this is great, thanks for making those changes. http://gerrit.cloudera.org:8080/#/c/8823/12/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/8823/12/src/kudu/client/scan_token-internal.cc@239 PS12, Line 239: IllegalState Consider making this InvalidArgument, since it's an error caused by the arguments of the caller, not a transient state issue. (here, below, and in client.cc) http://gerrit.cloudera.org:8080/#/c/8823/12/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/8823/12/src/kudu/client/scanner-internal.cc@365 PS12, Line 365: scan->set_propagated_timestamp(ts); This isn't changing so not an issue, but I'm curious if this is setting the propagated timestamp even for READ_LATEST mode? I though we didn't propagate in that mode, but maybe I'm misremembering. Or maybe it's just ignored on the server? -- To view, visit http://gerrit.cloudera.org:8080/8823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34214245a78aed172a28fbdb395ff5bccd0fc0e1 Gerrit-Change-Number: 8823 Gerrit-PatchSet: 12 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Fri, 23 Feb 2018 19:28:54 +0000 Gerrit-HasComments: Yes
