Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9326 )
Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase ...................................................................... Patch Set 3: (2 comments) SGTM except nits. Release failure looks unrelated. The TSAN failure may be legit, though. http://gerrit.cloudera.org:8080/#/c/9326/3/src/kudu/server/diagnostics_log.cc File src/kudu/server/diagnostics_log.cc: http://gerrit.cloudera.org:8080/#/c/9326/3/src/kudu/server/diagnostics_log.cc@104 PS3, Line 104: Unable to collect metrics to diagnostics log Add a bit saying we'll retry in `kWaitBetweenFailures` seconds. http://gerrit.cloudera.org:8080/#/c/9326/3/src/kudu/server/diagnostics_log.cc@118 PS3, Line 118: this seems redundant with the "only include changed metrics" above Referring to `opts.only_modified_in_or_after_epoch` below? -- To view, visit http://gerrit.cloudera.org:8080/9326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f7bc7335b1f4c2a5c62fc5fe672289d5027a10d Gerrit-Change-Number: 9326 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 20 Feb 2018 22:27:06 +0000 Gerrit-HasComments: Yes
