Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9326 )

Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase
......................................................................


Patch Set 7:

(1 comment)

nice clean lifecycle

http://gerrit.cloudera.org:8080/#/c/9326/7/src/kudu/server/diagnostics_log.cc
File src/kudu/server/diagnostics_log.cc:

http://gerrit.cloudera.org:8080/#/c/9326/7/src/kudu/server/diagnostics_log.cc@76
PS7, Line 76:   return Status::OK();
return s;



--
To view, visit http://gerrit.cloudera.org:8080/9326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f7bc7335b1f4c2a5c62fc5fe672289d5027a10d
Gerrit-Change-Number: 9326
Gerrit-PatchSet: 7
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Feb 2018 21:27:50 +0000
Gerrit-HasComments: Yes

Reply via email to