Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9326 to look at the new patch set (#4). Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase ...................................................................... KUDU-2297 (part 1): refactor metrics log out of ServerBase This is preparing for putting more information into the metrics log instead of just metrics snapshots. The logging code will get more complex as it gains features, so this makes a new class for it. This is slightly incompatible since I also changed the name on disk to 'diagnostics' instead of 'metrics' and updated the documentation, but I am not aware of people using this in the wild. So long as we release-note it, I think it's reasonable to expect any sophisticated operators to adjust their scripting accordingly. Change-Id: I1f7bc7335b1f4c2a5c62fc5fe672289d5027a10d --- M docs/administration.adoc M src/kudu/server/CMakeLists.txt A src/kudu/server/diagnostics_log.cc A src/kudu/server/diagnostics_log.h M src/kudu/server/server_base.cc M src/kudu/server/server_base.h 6 files changed, 240 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/9326/4 -- To view, visit http://gerrit.cloudera.org:8080/9326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1f7bc7335b1f4c2a5c62fc5fe672289d5027a10d Gerrit-Change-Number: 9326 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>