Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9378 )

Change subject: KUDU-2039: /masters can show the wrong list of masters
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/9378/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9378/2//COMMIT_MSG@7
PS2, Line 7: 2039
> 2309
Done


http://gerrit.cloudera.org:8080/#/c/9378/2//COMMIT_MSG@12
PS2, Line 12: quorum master
> nit: just "master"?
Done


http://gerrit.cloudera.org:8080/#/c/9378/2//COMMIT_MSG@13
PS2, Line 13:  it
> nit: "the new UUID, even though it may not be a part of the previously esta
Done


http://gerrit.cloudera.org:8080/#/c/9378/2/src/kudu/master/master.cc
File src/kudu/master/master.cc:

http://gerrit.cloudera.org:8080/#/c/9378/2/src/kudu/master/master.cc@308
PS2, Line 308: push_back
> nit: maybe, update this to be emplace_back(std::move(local_entry)) as well?
Done


http://gerrit.cloudera.org:8080/#/c/9378/2/src/kudu/master/master.cc@317
PS2, Line 317: auto config
> nit: for better readability, could this be 'const auto config' ?
Done



--
To view, visit http://gerrit.cloudera.org:8080/9378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I603ebc22e998bac9bd00edc939577ae339587f26
Gerrit-Change-Number: 9378
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 19:10:02 +0000
Gerrit-HasComments: Yes

Reply via email to