Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 )
Change subject: KUDU-2309: /masters can show the wrong list of masters ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9378/3/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/9378/3/src/kudu/master/master.cc@331 PS3, Line 331: LOG(WARNING) << s.ToString(); > Just another thought: maybe, it's worth at least add the UUID of the peer f Done http://gerrit.cloudera.org:8080/#/c/9378/3/www/masters.mustache File www/masters.mustache: http://gerrit.cloudera.org:8080/#/c/9378/3/www/masters.mustache@40 PS3, Line 40: {{^has_no_errors}} > Does it make sense to show this if there are no errors? Done http://gerrit.cloudera.org:8080/#/c/9378/4/www/masters.mustache File www/masters.mustache: http://gerrit.cloudera.org:8080/#/c/9378/4/www/masters.mustache@40 PS4, Line 40: {{^has_no_errors}} > mustache doesn't have a way to condition based on the length of the 'errors Yep. You can say "if the array is empty, do this" and "if the array is nonempty, do this for each element", but you can't say "if the array is nonempty, do this *once*", AFAIK. http://gerrit.cloudera.org:8080/#/c/9378/4/www/masters.mustache@40 PS4, Line 40: {{^has_no_errors}} > "An inverted section begins with a caret (hat) and ends with a slash. That In that case, the {{#errors}} section would need to surround the whole <table> element in order to have it be suppressed when there are no errors-- but then there'd be one table per error. I spent a bit of time trying things to make this exact situation work while doing previous mustache patches for Kudu, and I think this is the simplest way to do it. I'd be happy if someone had a better way, though. -- To view, visit http://gerrit.cloudera.org:8080/9378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I603ebc22e998bac9bd00edc939577ae339587f26 Gerrit-Change-Number: 9378 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 06 Mar 2018 17:06:26 +0000 Gerrit-HasComments: Yes
