Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 )
Change subject: KUDU-2309: /masters can show the wrong list of masters ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9378/3/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/9378/3/src/kudu/master/master.cc@331 PS3, Line 331: StatusToPB(s, peer_entry.mutable_error()); Just another thought: maybe, it's worth at least add the UUID of the peer from the Raft consensus info in that case? At least, that information is always available, so it's not hurt to have it even if it's not possible to verify that the UUID in the consensus and server registration match. -- To view, visit http://gerrit.cloudera.org:8080/9378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I603ebc22e998bac9bd00edc939577ae339587f26 Gerrit-Change-Number: 9378 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 22 Feb 2018 23:26:11 +0000 Gerrit-HasComments: Yes
