Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9280 )

Change subject: util: fix logged Kudu URL
......................................................................


Patch Set 3:

(3 comments)

> Patch Set 3:
>
> > It's not just for dev builds. What prompted the change was that I
>  > saw a production cluster point to http://.../1.7.0-cdh5.12/docs
>
> Definitely we want to remove the -cdh mumbo jumbo, but don't we want to keep 
> -SNAPSHOT? The link won't be any more broken now than a link to an unreleased 
> version, and if we do publish the website from master, then I think we should 
> have the -SNAPSHOT in the URL.

http://gerrit.cloudera.org:8080/#/c/9280/3/src/kudu/util/version_info.cc
File src/kudu/util/version_info.cc:

http://gerrit.cloudera.org:8080/#/c/9280/3/src/kudu/util/version_info.cc@25
PS3, Line 25: #include <regex.h>
> Ah I see...if it's busted then we shouldn't use it. Todd wrote that comment
Ack


http://gerrit.cloudera.org:8080/#/c/9280/3/src/kudu/util/version_info.cc@49
PS3, Line 49: "\\([[:digit:]]\\+\\.[[:digit:]]\\+\\.[[:digit:]]\\+\\)-.*"
> The crazy escaping may be the difference between the flavor of regex.h you'
Yeah, it really is weird. Even basing it on rpc/sasl_common.cc, I was expecting 
a different expression. Probably easier to just use std::regex


http://gerrit.cloudera.org:8080/#/c/9280/3/src/kudu/util/website_util.cc
File src/kudu/util/website_util.cc:

http://gerrit.cloudera.org:8080/#/c/9280/3/src/kudu/util/website_util.cc@37
PS3, Line 37: if (version_number.empty()) {
> If I read the regex right, if the version is not of the form "x.y.z-somethi
Yep, just noticed this too.



--
To view, visit http://gerrit.cloudera.org:8080/9280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48
Gerrit-Change-Number: 9280
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 20:34:45 +0000
Gerrit-HasComments: Yes

Reply via email to