Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9280 )
Change subject: util: fix logged Kudu URL ...................................................................... Patch Set 3: > Patch Set 3: > > (3 comments) > > > Patch Set 3: > > > > > It's not just for dev builds. What prompted the change was that I > > > saw a production cluster point to http://.../1.7.0-cdh5.12/docs > > > > Definitely we want to remove the -cdh mumbo jumbo, but don't we want to > > keep -SNAPSHOT? The link won't be any more broken now than a link to an > > unreleased version, and if we do publish the website from master, then I > > think we should have the -SNAPSHOT in the URL. Maybe, I guess it'd be dependent on if/how we implement a /dev version for the site. E.g. it could be we just use the version number, but slap on a warning at the top of every page saying it's just a dev snapshot and may not reflect the release, etc. That said, it's worth considering leaving any extra parsing up to the user, if they so choose to change version.txt themselves. Todd mentioned perhaps using s.apache.org, since it'd give us some flexibility, although I think going down that path would need some extra steps to how we build/release the site (maybe we should snatch s.apache.org/kudu_docs-X.Y.Z now? Although going down that root makes it a bit harder to link to specific pages) -- To view, visit http://gerrit.cloudera.org:8080/9280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48 Gerrit-Change-Number: 9280 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 22 Feb 2018 21:08:08 +0000 Gerrit-HasComments: No
