Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 )
Change subject: KUDU-2290: Tool to re-create a tablet ...................................................................... Patch Set 2: (5 comments) Mostly some nits and high-level points http://gerrit.cloudera.org:8080/#/c/9393/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9393/2//COMMIT_MSG@9 PS2, Line 9: replace_tablet nit: how about unsafe_replace_tablet, given we're guaranteed "data loss" http://gerrit.cloudera.org:8080/#/c/9393/2//COMMIT_MSG@13 PS2, Line 13: Before, the table would : have to be recreated to recover from a permanently lost tablet Maybe we should add a check somewhere that we don't actually have a live tablet somewhere. And if we do (or think we do), block the run with a `--force` flag or somesuch. http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/master/master.proto@712 PS2, Line 712: there an e nit: there is an http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/tools/kudu-tool-test.cc@2371 PS2, Line 2371: const int kNumTservers = 3; : const int kNumTablets = 3; Maybe test with multiple masters too? This would still work, right? http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/tools/kudu-tool-test.cc@2392 PS2, Line 2392: // Replace the tablet. This isn't the use case for the tool, but it should work. Should it? Maybe we should safeguard against users shooting themselves in the foot. -- To view, visit http://gerrit.cloudera.org:8080/9393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbefbde68e3ca724f04efe0426a3906e5c33ed3c Gerrit-Change-Number: 9393 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 23 Feb 2018 00:25:31 +0000 Gerrit-HasComments: Yes
