Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 )
Change subject: KUDU-2290: Tool to re-create a tablet ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/master/catalog_manager.h@577 PS2, Line 577: , causing all of its data : // to be permanently lost. Would it be feasible to turn the replaced tablet into a new single-tablet table, so that if you eventually were able to repair it, you could at least get the data back out of it? http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/master/catalog_manager.cc@4249 PS2, Line 4249: replaced_tablet->mutable_metadata()->mutable_dirty()->set_state(SysTabletsEntryPB::DELETED, if we make it DELETED it will also get removed off of the tablet servers. we might want to keep it there for some investigation or attempts to recover the data. Is there a way we can accomplish that? http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/master/master.proto@792 PS2, Line 792: option (kudu.rpc.authz_method) = "AuthorizeService"; we don't want AuthorizeSuperUser here? http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/master/master_service.cc@517 PS2, Line 517: LOG(INFO) << "ReplaceTablet: received request to replace tablet " << req->tablet_id(); worth logging the requestor info too -- To view, visit http://gerrit.cloudera.org:8080/9393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbefbde68e3ca724f04efe0426a3906e5c33ed3c Gerrit-Change-Number: 9393 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 23 Feb 2018 23:19:10 +0000 Gerrit-HasComments: Yes
