Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 )
Change subject: KUDU-2290: Tool to re-create a tablet ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9393/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9393/4//COMMIT_MSG@23 PS4, Line 23: Note that, if the : tablet recovers quickly enough after being replaced, > This procedure would amount to scanning the new table and dumping the rows Did you mean to comment on the previous sentence? If so, the answer is yup. http://gerrit.cloudera.org:8080/#/c/9393/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/9393/4/src/kudu/tools/kudu-tool-test.cc@2405 PS4, Line 2405: replaced_tablet_id > nit: could we use "old"/"new" instead of "replaced" here? I'm conflicted be Done http://gerrit.cloudera.org:8080/#/c/9393/4/src/kudu/tools/kudu-tool-test.cc@2445 PS4, Line 2445: replica > nit: tablet Done http://gerrit.cloudera.org:8080/#/c/9393/4/src/kudu/tools/kudu-tool-test.cc@2445 PS4, Line 2445: plus one new one. > This is referring to the new tablet count, not the number of replicas, righ Done -- To view, visit http://gerrit.cloudera.org:8080/9393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbefbde68e3ca724f04efe0426a3906e5c33ed3c Gerrit-Change-Number: 9393 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 13 Mar 2018 06:23:22 +0000 Gerrit-HasComments: Yes
