Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9326 )
Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase ...................................................................... Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9326/7/src/kudu/server/diagnostics_log.cc File src/kudu/server/diagnostics_log.cc: http://gerrit.cloudera.org:8080/#/c/9326/7/src/kudu/server/diagnostics_log.cc@96 PS7, Line 96: MonoDelta::FromSeconds(60) > eh I think it's rare enough that it's not really worth the flag (even a hid alright -- To view, visit http://gerrit.cloudera.org:8080/9326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f7bc7335b1f4c2a5c62fc5fe672289d5027a10d Gerrit-Change-Number: 9326 Gerrit-PatchSet: 8 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 23 Feb 2018 02:07:51 +0000 Gerrit-HasComments: Yes