David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 )
Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/8823/13/src/kudu/integration-tests/consistency-itest.cc File src/kudu/integration-tests/consistency-itest.cc: http://gerrit.cloudera.org:8080/#/c/8823/13/src/kudu/integration-tests/consistency-itest.cc@767 PS13, Line 767: // Verify read-your-reads session guarantees. : { : shared_ptr<KuduClient> client; : ASSERT_OK(cluster_->CreateClient(nullptr, &client)); : shared_ptr<KuduTable> table; : ASSERT_OK(client->OpenTable(table_name_, &table)); : : ASSERT_OK(InsertTestRows(client.get(), table.get(), 1, : rows_to_insert)); : size_t row_count; : ASSERT_OK(GetRowCount(table.get(), KuduScanner::READ_YOUR_WRITES, : sel, 0, &row_count)); : ASSERT_OK(InsertTestRows(client.get(), table.get(), rows_to_insert, : rows_to_insert + 1)); : size_t new_row_count; : ASSERT_OK(GetRowCount(table.get(), KuduScanner::READ_YOUR_WRITES, : sel, 0, &new_row_count)); : EXPECT_EQ(rows_to_insert + row_count, new_row_count); : } Thanks for adding the comment, but it still doesn't say _how_ this is testing read-your-reads... can you please clarify on that? I mean I see that this is testing that it can see what it previously wrote (RYW) but how is it testing that it can always at least see what it previously read? Since with RYW a client always will observe it's own writes, it seems to me that another client is needed to specifically test RYR, no? -- To view, visit http://gerrit.cloudera.org:8080/8823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34214245a78aed172a28fbdb395ff5bccd0fc0e1 Gerrit-Change-Number: 8823 Gerrit-PatchSet: 13 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 23 Feb 2018 23:14:10 +0000 Gerrit-HasComments: Yes
