Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 )
Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/8823/13/src/kudu/integration-tests/consistency-itest.cc File src/kudu/integration-tests/consistency-itest.cc: http://gerrit.cloudera.org:8080/#/c/8823/13/src/kudu/integration-tests/consistency-itest.cc@767 PS13, Line 767: sel, 0, &row_count)); : EXPECT_EQ(rows_to_insert, row_count); : : row_count = 0; : ASSERT_OK(GetRowCount(table.get(), KuduScanner::READ_YOUR_WRITES, : sel, 0, &row_count)); : EXPECT_EQ(rows_to_insert, row_count); : } : : const KuduClient::ReplicaSelection replica_selectors[] = { : KuduClient::LEADER_ONLY, : KuduClient::CLOSEST_REPLICA, : KuduClient::FIRST_REPLICA, : }; : : INSTANTIATE_TEST_CASE_P(Params, ScanYourWritesParamTest, : testing::ValuesIn(replica_selectors)); : : cla > Thanks for adding the comment, but it still doesn't say _how_ this is testi Discussed this on slack with David. And addressed his concern in the ScanYourWritesMultiClientsParamTest instead of this one. -- To view, visit http://gerrit.cloudera.org:8080/8823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34214245a78aed172a28fbdb395ff5bccd0fc0e1 Gerrit-Change-Number: 8823 Gerrit-PatchSet: 14 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Sat, 24 Feb 2018 00:48:30 +0000 Gerrit-HasComments: Yes
