Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9373 )
Change subject: KUDU-2319 follower masters should be able to verify authn tokens ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/9373/11/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9373/11/src/kudu/master/catalog_manager.cc@1034 PS11, Line 1034: } else { : if (!key this can be un-nested one level with an 'else if', which I think will make it easier to follow as well. http://gerrit.cloudera.org:8080/#/c/9373/11/src/kudu/master/catalog_manager.cc@1042 PS11, Line 1042: ) in this case would lead to : // waiting till next cycle of TSK rotation. Returning non-OK status will : // make the periodic task of CatalogManagerBgTasks::Run() to retry : // fetching the keys. I'm not seeing how the return status from this method is effecting CatalogManagerBgTasks::Run() in this way. From what I can see it's simply logging a warning if it's a non-OK success status. Either way it appears to go back through the loop 1 second later (line 569)? -- To view, visit http://gerrit.cloudera.org:8080/9373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcc92dd4fae3d555af563d86634c07d3d06147a7 Gerrit-Change-Number: 9373 Gerrit-PatchSet: 11 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 02 Mar 2018 17:52:06 +0000 Gerrit-HasComments: Yes
