Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9373 )
Change subject: KUDU-2319 follower masters should be able to verify authn tokens ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/9373/11/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9373/11/src/kudu/master/catalog_manager.cc@1034 PS11, Line 1034: } else { : if (!key > this can be un-nested one level with an 'else if', which I think will make I updated this code to be easier to follow. http://gerrit.cloudera.org:8080/#/c/9373/11/src/kudu/master/catalog_manager.cc@1042 PS11, Line 1042: ) in this case would lead to : // waiting till next cycle of TSK rotation. Returning non-OK status will : // make the periodic task of CatalogManagerBgTasks::Run() to retry : // fetching the keys. > I'm not seeing how the return status from this method is effecting CatalogM The return status from this methods affects whether the PrepareFollower() method updates its output parameter 'last_tspk_run'. Yes, the CatalogManagerBgTasks::Run() runs with its own interval, but PrepareFollowerTokenVerifier() will not be called until enough time has passed to expect a new TSK to appear. -- To view, visit http://gerrit.cloudera.org:8080/9373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcc92dd4fae3d555af563d86634c07d3d06147a7 Gerrit-Change-Number: 9373 Gerrit-PatchSet: 11 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 02 Mar 2018 19:39:27 +0000 Gerrit-HasComments: Yes
