Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9373 )
Change subject: KUDU-2319 follower masters should be able to verify authn tokens ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/9373/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9373/6/src/kudu/master/catalog_manager.cc@1050 PS6, Line 1050: MonoDelta::FromSeconds(FLAGS_tsk_rotation_seconds); : const auto now = MonoTime::Now(); > Seems like these first two clauses can be removed if you just initialize 'l Huh, it turned out that initializing last_tspk_run with MonoTime::Min() was not a good idea, not at all. The catch is that MonoTime::Now() is not based on wall clock, it's just some monotonic kernel clock. I waste a lot of time trying to understand why the test passes on my machines but fails at dist-test machines. -- To view, visit http://gerrit.cloudera.org:8080/9373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcc92dd4fae3d555af563d86634c07d3d06147a7 Gerrit-Change-Number: 9373 Gerrit-PatchSet: 10 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sat, 24 Feb 2018 06:05:08 +0000 Gerrit-HasComments: Yes
