Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9378 )
Change subject: KUDU-2309: /masters can show the wrong list of masters ...................................................................... KUDU-2309: /masters can show the wrong list of masters The ListMasters RPC (on which the /masters page is based) returned masters based on the -master_addresses flag. It should return masters based on the consensus configuration. Since we verify the two sets of addresses are the same at startup, this usually makes no difference. However, if a master is replaced by a server with a new UUID, previously we would report the new UUID, even though it may not be part of the previously established quorum. This patch adds an additional check that the UUIDs match, and returns an error along with the registration information if there is a mismatch. Screenshot for down master: https://github.com/wdberkeley/kudu/blob/kudu2309screenshots/www/mastersonedown.png Screenshot for UUID mismatch: https://github.com/wdberkeley/kudu/blob/kudu2309screenshots/www/mastersmismatch.png Change-Id: I603ebc22e998bac9bd00edc939577ae339587f26 Reviewed-on: http://gerrit.cloudera.org:8080/9378 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/master/master.cc M src/kudu/master/master_path_handlers.cc M src/kudu/master/sys_catalog.h M www/masters.mustache 4 files changed, 53 insertions(+), 27 deletions(-) Approvals: Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I603ebc22e998bac9bd00edc939577ae339587f26 Gerrit-Change-Number: 9378 Gerrit-PatchSet: 6 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
