Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 )
Change subject: [WIP] updated to use READ_YOUR_WRITES scan mode for Jepsen tests ...................................................................... Patch Set 1: (4 comments) > (5 comments) > > we'll also need to test RYR, which I'm not sure the register test > can do, since it only writes a single row. > > cockroachdb has a good set of tests that we might want to look at: > https://github.com/jepsen-io/jepsen/tree/master/cockroachdb Thanks for sharing that! I will take a look. http://gerrit.cloudera.org:8080/#/c/9526/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9526/1//COMMIT_MSG@9 PS1, Line 9: This patches updated the Jespen tests to use READ_YOUR_WRITES scan mode. > we're supposed to have both eventually right? Right, this is just a WIP patch. Eventually I will add an option to select which mode to use. http://gerrit.cloudera.org:8080/#/c/9526/1//COMMIT_MSG@14 PS1, Line 14: https://drive.google.com/file/d/1jW1CeGjB9AdnJZ2XbhJrf0IyOwXnKC_p/view?usp=sharing > thanks for sharing this. So as discussed on slack I think the exception "Snapshot timestamp is earlier than the ancient history mark. Consider increasing the value of the configuration parameter --tablet_history_max_age_sec. Snapshot timestamp: P: 0 usec, L: 1 Ancient History Mark: P: 1520385210671765 usec, L: 0 Physical time difference: -1520385210.672s" may be caused by the safe time is not correctly advanced yet(similar to KUDU-2233). Do you think so? http://gerrit.cloudera.org:8080/#/c/9526/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj: http://gerrit.cloudera.org:8080/#/c/9526/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj@36 PS1, Line 36: [table-created? kclient ktable] : (reify jepsen.client/Client : (setup! [_ test _] : "Create the client and the test table. Use the same Kudu client instance " : "across all test actors to achieve timestamp propagation for all " : "operations." : (let [kclient (kc/sync-client (:master-addresses test)) : table-name (:table-name test) : ktable (locking table-created? : (when (compare-and-set! table-created? false true) : (kc/create-table : kclient : table-name : kt/kv-table-schema : (let [ranges (:table-ranges test) : rep-factor (:num-replicas test)] : (if (nil? ranges) : (kt/kv-table-options-hash rep-factor (count (:tservers test))) : (kt/kv-table-options-range rep-factor ranges))))) : (kc/open-table kclient table-name))] : (client table-created? kclient ktable))) > this is just a revert of the changes we made to have 1 client per table, vs Yes, agree. http://gerrit.cloudera.org:8080/#/c/9526/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj: http://gerrit.cloudera.org:8080/#/c/9526/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj@100 PS1, Line 100: READ_YOUR_WRITES > this will have to be a parameter Agree. -- To view, visit http://gerrit.cloudera.org:8080/9526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d5c0e3b91af58576eb6cd408d922ec7c0fef6c Gerrit-Change-Number: 9526 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 07 Mar 2018 19:06:13 +0000 Gerrit-HasComments: Yes
