Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 )
Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/9526/4/java/kudu-jepsen/pom.xml File java/kudu-jepsen/pom.xml: http://gerrit.cloudera.org:8080/#/c/9526/4/java/kudu-jepsen/pom.xml@43 PS4, Line 43: READ_AT_SNAPSHOT > I'm not sure this should be a parameter of the overall test. Maybe, instea Hmm, I am not quite sure. Wouldn't add an option to specify the scan mode be more clear on which scan mode may have problems when the test is failing? http://gerrit.cloudera.org:8080/#/c/9526/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj: http://gerrit.cloudera.org:8080/#/c/9526/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@21 PS4, Line 21: > this file needs _a lot_ more comments. it's important as this is a fundamen Done http://gerrit.cloudera.org:8080/#/c/9526/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj: http://gerrit.cloudera.org:8080/#/c/9526/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj@109 PS4, Line 109: kv-count > nit this is not necessarily only for "key/value" tables, it shouild be able Done -- To view, visit http://gerrit.cloudera.org:8080/9526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d5c0e3b91af58576eb6cd408d922ec7c0fef6c Gerrit-Change-Number: 9526 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Apr 2018 18:52:31 +0000 Gerrit-HasComments: Yes
