David Ribeiro Alves has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9526 )

Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode
......................................................................


Patch Set 4:

(2 comments)

Thanks for this valiant effort. This is very good stuff, but the juicier bits 
are hard to review due to missing docs...

http://gerrit.cloudera.org:8080/#/c/9526/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj
File java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj:

http://gerrit.cloudera.org:8080/#/c/9526/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@21
PS4, Line 21:
this file needs _a lot_ more comments. it's important as this is a 
fundamentally new checker and other folks might need to maintain this code the 
(defn client) part is pretty straighforward and boilerplate, but the rest needs 
pretty good docs (here or elsewhere)


http://gerrit.cloudera.org:8080/#/c/9526/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj
File java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj:

http://gerrit.cloudera.org:8080/#/c/9526/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj@109
PS4, Line 109: kv-count
nit this is not necessarily only for "key/value" tables, it shouild be able to 
count the rows of any table right?



--
To view, visit http://gerrit.cloudera.org:8080/9526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92d5c0e3b91af58576eb6cd408d922ec7c0fef6c
Gerrit-Change-Number: 9526
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 12 Apr 2018 22:21:42 +0000
Gerrit-HasComments: Yes

Reply via email to