Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9591
to review the following change.
Change subject: diagnostics_log: fix an assertion failure for null stack frames
......................................................................
diagnostics_log: fix an assertion failure for null stack frames
On my Ubuntu 16 box, in ASAN builds, it seems I sometimes get a stack
frame with a nullptr address. This caused SymbolSet::Add(...) to fail an
assertion since it uses google::dense_hash_set<> which requires that
there be one key reserved as a non-insertable "empty" marker. We were
using nullptr for that but not checking before potentially inserting it.
This adds a simple workaround. Without the patch, if I started a tserver
with --diagnostics-log-stack-traces-interval-ms=10, it would crash about
10% of the time with the following assertion failure:
Change-Id: I73ada54bef056b665c03ca142a3995ae6ad59230
kudu-master:
../../thirdparty/installed/common/include/sparsehash/internal/densehashtable.h:969:
std::pair<iterator, bool> google::dense_hashtable<void *, void *,
std::hash<void *>, google::dense_hash_set<void *, std::hash<void *>,
std::equal_to<void *>, google::libc_allocator_with_realloc<void *> >::Identity,
google::dense_hash_set<void *, std::hash<void *>, std::equal_to<void *>,
google::libc_allocator_with_realloc<void *> >::SetKey, std::equal_to<void *>,
google::libc_allocator_with_realloc<void *> >::insert_noresize(K &&, Args
&&...) [Value = void *, Key = void *, HashFcn = std::hash<void *>, ExtractKey =
google::dense_hash_set<void *, std::hash<void *>, std::equal_to<void *>,
google::libc_allocator_with_realloc<void *> >::Identity, SetKey =
google::dense_hash_set<void *, std::hash<void *>, std::equal_to<void *>,
google::libc_allocator_with_realloc<void *> >::SetKey, EqualKey =
std::equal_to<void *>, Alloc = google::libc_allocator_with_realloc<void *>, K =
void *const &, Args = <void *const &>]: Assertion
`!equals(std::forward<K>(key), key_info.empty_key) && "Inserting the empty
key"' failed.
---
M src/kudu/server/diagnostics_log.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9591/1
--
To view, visit http://gerrit.cloudera.org:8080/9591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73ada54bef056b665c03ca142a3995ae6ad59230
Gerrit-Change-Number: 9591
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
