Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9591 )
Change subject: diagnostics_log: fix an assertion failure for null stack frames ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9591/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9591/1//COMMIT_MSG@7 PS1, Line 7: diagnostics_log: fix an assertion failure for null stack frames > You can tag KUDU-2336 here. ah I missed that this was filed. Done. http://gerrit.cloudera.org:8080/#/c/9591/1//COMMIT_MSG@20 PS1, Line 20: kudu-master: ../../thirdparty/installed/common/include/sparsehash/internal/densehashtable.h:969: std::pair<iterator, bool> google::dense_hashtable<void *, void *, std::hash<void *>, google::dense_hash_set<void *, std::hash<void *>, std::equal_to<void *>, google::libc_allocator_with_realloc<void *> >::Identity, google::dense_hash_set<void *, std::hash<void *>, std::equal_to<void *>, google::libc_allocator_with_realloc<void *> >::SetKey, std::equal_to<void *>, google::libc_allocator_with_realloc<void *> >::insert_noresize(K &&, Args &&...) [Value = void *, Key = void *, HashFcn = std::hash<void *>, ExtractKey = google::dense_hash_set<void *, std::hash<void *>, std::equal_to<void *>, google::libc_allocator_with_realloc<void *> >::Identity, SetKey = google::dense_hash_set<void *, std::hash<void *>, std::equal_to<void *>, google::libc_allocator_with_realloc<void *> >::SetKey, EqualKey = std::equal_to<void *>, Alloc = google::libc_allocator_with_realloc<void *>, K = void *const &, Args = <void *const &>]: Assertion `!equals(std::forward<K>(key), key_info.empty_key) && "Inserting the empty key"' failed. > Nit: could you move this be to about Change-Id? And maybe reformat/elide so ah, git hook gone awry -- To view, visit http://gerrit.cloudera.org:8080/9591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73ada54bef056b665c03ca142a3995ae6ad59230 Gerrit-Change-Number: 9591 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 12 Mar 2018 23:22:33 +0000 Gerrit-HasComments: Yes
