Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/inbound_call.h File src/kudu/rpc/inbound_call.h: http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/inbound_call.h@253 PS1, Line 253: outbound_sidecars_size_ I think 'total_size_' or 'size_bytes_' or something is more clear, since 'size' is often used to mean the length of a vector rather than the number of bytes http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/inbound_call.cc File src/kudu/rpc/inbound_call.cc: http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/inbound_call.cc@186 PS1, Line 186: absolute_sidecar_offset - protobuf_msg_size these are both uint32_t, right? maybe we should change absolute_sidecar_offset to int64 above so the assertion is less likely to be dealing with an overflow if something goes wrong? http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/inbound_call.cc@221 PS1, Line 221: exceeds limit would exceed http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/rpc_controller.h File src/kudu/rpc/rpc_controller.h: http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/rpc_controller.h@275 PS1, Line 275: int64_t outbound_sidecars_size_ = 0; same comment as on the InboundCall http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/rpc_controller.cc File src/kudu/rpc/rpc_controller.cc: http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/rpc_controller.cc@153 PS1, Line 153: exceeds limit would exceed http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/transfer.h File src/kudu/rpc/transfer.h: http://gerrit.cloudera.org:8080/#/c/9601/1/src/kudu/rpc/transfer.h@51 PS1, Line 51: kMaxTotalSidecarSize = INT_MAX it seems elsewhere in this patch you are checking against INT_MAX instead of kMaxTotalSidecarSize -- To view, visit http://gerrit.cloudera.org:8080/9601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d041e214b15d9c22b810588643798e2b3bc5c24 Gerrit-Change-Number: 9601 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 13 Mar 2018 14:59:44 +0000 Gerrit-HasComments: Yes
