Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9601/2/src/kudu/rpc/outbound_call.cc File src/kudu/rpc/outbound_call.cc: http://gerrit.cloudera.org:8080/#/c/9601/2/src/kudu/rpc/outbound_call.cc@161 PS2, Line 161: // SerializeMessage() takes the additional_size as an int32_t. Protect against : // any overflow. : CHECK_LE(sidecar_byte_size_, std::numeric_limits<int32_t>::max()); Why not just replace additional_size with uint32_t and avoid this CHECK() altogether ? http://gerrit.cloudera.org:8080/#/c/9601/2/src/kudu/rpc/serialization.cc File src/kudu/rpc/serialization.cc: http://gerrit.cloudera.org:8080/#/c/9601/2/src/kudu/rpc/serialization.cc@57 PS2, Line 57: int additional_size Why is this not uint32_t ? -- To view, visit http://gerrit.cloudera.org:8080/9601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d041e214b15d9c22b810588643798e2b3bc5c24 Gerrit-Change-Number: 9601 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 14 Mar 2018 18:56:42 +0000 Gerrit-HasComments: Yes
