Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9489 )
Change subject: KUDU-2230: java: sync client exception stack traces should make sense ...................................................................... Patch Set 2: > Actually I just remembered why I didn't switch the cause. The cause of an > exception can only be set once using 'initCause' and not replaced later. So, > to use 'cause', we'd need to instantiate a new KuduException in the > transformException function. > > In order to do so, we'd have two options: > > a) use some reflection to figure out which KuduException subclass we had and > try to re-instantiate the same one. That seems ugly. > b) use clone() and make sure that all KuduException subclasses are Cloneable. > Also kind of a pain, no? Agreed. Both of those are bad news bears. Ship It. -- To view, visit http://gerrit.cloudera.org:8080/9489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I874d47b5239bcc8493c15ef763ecfe0fd878d795 Gerrit-Change-Number: 9489 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 13 Mar 2018 17:12:02 +0000 Gerrit-HasComments: No
