Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9489 )
Change subject: KUDU-2230: java: sync client exception stack traces should make sense ...................................................................... Patch Set 2: Why did you choose to model the original exception as suppressed rather than as the cause of the new exception? From my reading of suppressed exceptions, it seems like it's used when there's no causal link between two exceptions (e.g. a second exception thrown while cleaning up in a try-with-resources block). But in this case there is a causal link. Dan was also curious about this (he asked the same thing on Slack). -- To view, visit http://gerrit.cloudera.org:8080/9489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I874d47b5239bcc8493c15ef763ecfe0fd878d795 Gerrit-Change-Number: 9489 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 12 Mar 2018 22:55:51 +0000 Gerrit-HasComments: No
