Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9601/2/src/kudu/rpc/outbound_call.cc File src/kudu/rpc/outbound_call.cc: http://gerrit.cloudera.org:8080/#/c/9601/2/src/kudu/rpc/outbound_call.cc@161 PS2, Line 161: : : Status OutboundCall::status() const { > That makes sense to me. I'm working on that change. Yea, we don't have the warnings enabled for the integer casts, but perhaps we should. The reason we didn't turn it on long ago is that it makes common loops like: for (int i = 0; i < foo.size(); i++) {} complain because vector::size is int64, etc. Given C++11 for-range loops, though, I think those are relatively less common (I count 134 currently). We do have UBSAN enabled for our test builds, but being a dynamic check it relies on us actually exercising these corner cases. -- To view, visit http://gerrit.cloudera.org:8080/9601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d041e214b15d9c22b810588643798e2b3bc5c24 Gerrit-Change-Number: 9601 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 23:51:16 +0000 Gerrit-HasComments: Yes
