Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9715 )
Change subject: [build] Reduce the chances of a build abort corrupting the build ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/9715/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/9715/1/thirdparty/download-thirdparty.sh@35 PS1, Line 35: kudu-download-complete nit: all those file are kind of auxiliary, any maybe it's better to name them like in 'dot-style pattern', e.g. .kudu-download-complete ? http://gerrit.cloudera.org:8080/#/c/9715/1/thirdparty/download-thirdparty.sh@52 PS1, Line 52: unzip_to_source nit: this looks a bit strange to me. Maybe, rename into unzip_to_src_dir ? http://gerrit.cloudera.org:8080/#/c/9715/1/thirdparty/download-thirdparty.sh@57 PS1, Line 57: head -n1 | tr -s ' ' | cut -d' ' -f5- | tr -d '/' I'm not sure this gives the directory name. I tried this with archives which contain just a single file in a dir (like artifacts from dist-test), and this gives the filename. http://gerrit.cloudera.org:8080/#/c/9715/1/thirdparty/download-thirdparty.sh@124 PS1, Line 124: install_and_patch How about 'fetch_and_patch' ? -- To view, visit http://gerrit.cloudera.org:8080/9715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34b5065ebaf09503b0dc6daf11b962f5a41f7d76 Gerrit-Change-Number: 9715 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 19 Mar 2018 17:45:13 +0000 Gerrit-HasComments: Yes
