Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9715 )

Change subject: [build] Reduce the chances of a build abort corrupting the build
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9715/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:

http://gerrit.cloudera.org:8080/#/c/9715/1/thirdparty/download-thirdparty.sh@57
PS1, Line 57:  head -n1 | tr -s ' ' | cut -d' ' -f5- | tr -d '/'
> Right, this wouldn't work on single file archives. It gives the first file,
That does not work not only for a single-file archives, but for multi-file 
archives as well if all files are at the same level:

zip-test$ unzip -qql 
aserbin.1520649736.16763.5f82d97ad58006bea415e492185aca88af8bcd73.667.0-artifacts.zip
    77752  03-10-18 02:48   
build/kudu-2295-update.asan/test-logs/raft_consensus_stress-itest.0.txt
     1335  03-10-18 02:48   
build/kudu-2295-update.asan/test-logs/raft_consensus_stress-itest.0.xml

Maybe, it's worth making this to work in such cases as well?



--
To view, visit http://gerrit.cloudera.org:8080/9715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34b5065ebaf09503b0dc6daf11b962f5a41f7d76
Gerrit-Change-Number: 9715
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Mon, 19 Mar 2018 19:38:06 +0000
Gerrit-HasComments: Yes

Reply via email to