Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9715 )

Change subject: [build] Reduce the chances of a build abort corrupting the build
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9715/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:

http://gerrit.cloudera.org:8080/#/c/9715/1/thirdparty/download-thirdparty.sh@57
PS1, Line 57:  head -n1 | tr -s ' ' | cut -d' ' -f5- | tr -d '/'
> I don't want it to be generic. I want it to be simple for what we need.
Does the following looks to be much complex:

DIR_NAME=`unzip -qql "$FILENAME" | awk 'NR==1 {print $4}' | sed -e 
's|^[/]*\([^/]*\).*|\1|'`

?



--
To view, visit http://gerrit.cloudera.org:8080/9715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34b5065ebaf09503b0dc6daf11b962f5a41f7d76
Gerrit-Change-Number: 9715
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Mon, 19 Mar 2018 21:34:12 +0000
Gerrit-HasComments: Yes

Reply via email to