Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9719 )
Change subject: [rpc-test] OS X-specific fix for TestRpcSidecarLimits ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9719/2/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/9719/2/src/kudu/rpc/rpc-test.cc@746 PS2, Line 746: // macOS sendmsg(): iov_len values overflows an ssize_t > Another option would be to use a smaller string for macOS on line 725 (but Yep, but I think it's better to keep the scenarios between OS X and Linux in sync, if possible. -- To view, visit http://gerrit.cloudera.org:8080/9719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf Gerrit-Change-Number: 9719 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 20 Mar 2018 03:14:48 +0000 Gerrit-HasComments: Yes
