Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9719 )
Change subject: [rpc-test] OS X-specific fix for TestRpcSidecarLimits ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/9719/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9719/2//COMMIT_MSG@7 PS2, Line 7: OS X nit: s/OS X/macOS/g http://gerrit.cloudera.org:8080/#/c/9719/2//COMMIT_MSG@10 PS2, Line 10: running the test The test only failed with SSL disabled. Do we understand why? http://gerrit.cloudera.org:8080/#/c/9719/2//COMMIT_MSG@16 PS2, Line 16: the new scenario nit: Could you mention what the scenario is (i.e. that the sum of the iov_len values overflows an ssize_t). http://gerrit.cloudera.org:8080/#/c/9719/2/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/9719/2/src/kudu/rpc/rpc-test.cc@746 PS2, Line 746: overflows nit: Clearer to say the sum of the iov_len values overflows an ssize_t. -- To view, visit http://gerrit.cloudera.org:8080/9719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf Gerrit-Change-Number: 9719 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 20 Mar 2018 06:17:23 +0000 Gerrit-HasComments: Yes
