Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9719 )
Change subject: [rpc-test] macOS-specific fix for TestRpcSidecarLimits ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9719/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9719/2//COMMIT_MSG@7 PS2, Line 7: macO > nit: s/OS X/macOS/g Done http://gerrit.cloudera.org:8080/#/c/9719/2//COMMIT_MSG@10 PS2, Line 10: running the tes > The test only failed with SSL disabled. Do we understand why? Because for SSL-enabled version the output error message matches one of already existing patterns. http://gerrit.cloudera.org:8080/#/c/9719/2//COMMIT_MSG@16 PS2, Line 16: he sum of the io > nit: Could you mention what the scenario is (i.e. that the sum of the iov_l Done http://gerrit.cloudera.org:8080/#/c/9719/2/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/9719/2/src/kudu/rpc/rpc-test.cc@746 PS2, Line 746: iov_len > nit: Clearer to say the sum of the iov_len values overflows an ssize_t. Done -- To view, visit http://gerrit.cloudera.org:8080/9719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf Gerrit-Change-Number: 9719 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 20 Mar 2018 14:50:20 +0000 Gerrit-HasComments: Yes
